Just want to keep it consistent with util/nrv2b/nrv2b.c

YH

-----Original Message-----
From: Stefan Reinauer [mailto:[EMAIL PROTECTED] 
Sent: Wednesday, May 03, 2006 3:44 PM
To: Lu, Yinghai
Cc: [email protected]
Subject: Re: [LinuxBIOS] [FEATURE] payload compression

* Lu, Yinghai <[EMAIL PROTECTED]> [060503 20:40]:
> Please check the attached zrom fix up.
> 1. copy_and_run.c double skip length
> 2. merge zrom_stream.c into rom_stream.c
> 3. ram position check to skip 0xa0000, and 0xf0000...

I suggest you drop the following from the patch:

+#if ENDIAN == 0 && BITSIZE == 8
+#define GETBIT(bb, src, ilen) GETBIT_8(bb, src, ilen)
+#endif
+#if ENDIAN == 0 && BITSIZE == 16
+#define GETBIT(bb, src, ilen) GETBIT_LE16(bb, src, ilen)
+#endif
+#if ENDIAN == 0 && BITSIZE == 32
+#define GETBIT(bb, src, ilen) GETBIT_LE32(bb, src, ilen)
+#endif

The algorithm does not work with anything than 32bit and little endian
anyways as it is written down.

Stefan

-- 
coresystems GmbH * Brahmsstr. 16 * D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 * Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  * http://www.coresystems.de/



-- 
linuxbios mailing list
[email protected]
http://www.openbios.org/mailman/listinfo/linuxbios

Reply via email to