Hi,

On Wed, Nov 15, 2006 at 09:37:36AM +0100, Giampiero Giancipoli wrote:
> Furthermore, the patch adds support for the SyncMos S29C51002T 256K
> flash. Tested successfully on a Boser HS-2603. It is high probable that
> the same configuration would work with all the chips of the same family.

Please provide separate patches for separate issues. And please sign-off
your patches by adding
  Signed-off-by: Giampiero Giancipoli <[EMAIL PROTECTED]>
in your email. See http://www.linuxbios.org/Development_Guidelines
for details.


> Index: flashchips.c
> ===================================================================
> --- flashchips.c      (revision 2497)
> +++ flashchips.c      (working copy)
> @@ -114,6 +114,8 @@
>  #endif
>       {"LHF00L04",    SHARP_ID,               SHARP_LHF00L04,         NULL, 
> 1024, 64 * 1024,
>        probe_lhf00l04, erase_lhf00l04,        write_lhf00l04, NULL},
> +     {"S29C51002T",  SM_ID,  S29C51002T,     NULL, 256, 128,
> +      probe_jedec,   erase_chip_jedec, write_49f002, NULL},
>       {NULL,}
>  };

I cannot test the first part of your patch right now, but the second
part does not compile. You're using SM_ID and S29C51002T which are
not defined anywhere. You have to add them to flash.h, I think.


Cheers, Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

Attachment: signature.asc
Description: Digital signature

-- 
linuxbios mailing list
[email protected]
http://www.openbios.org/mailman/listinfo/linuxbios

Reply via email to