Explicitly set the CLKIN to 24 MHz on all ITE Super I/Os, otherwise serial output might not always work (correctly). Thanks Philipp Degler <[EMAIL PROTECTED]> for testing and reporting this issue.
Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]> --- On Wed, Nov 29, 2006 at 01:51:27PM +0100, Philipp Degler wrote: > we've tested the it8712f code, too. We see serial output on our ASUS a8ne. It > is equiped with a ck804 SB and 1GB of RAM and a Athlon64 CPU. > > But we needed to set the clock to 24MHz in order to see valid serial output. > > Index: src/superio/ite/it8712f/it8712f_early_serial.c > =================================================================== > --- src/superio/ite/it8712f/it8712f_early_serial.c (Revision 2507) > +++ src/superio/ite/it8712f/it8712f_early_serial.c (Arbeitskopie) > @@ -78,7 +78,7 @@ > it8712f_sio_write(IT8712F_IR, 0x30, 0x1); /* Consumer IR */ > > /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */ > - /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */ > + it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); > > /* Clear software suspend mode (clear bit 0). TODO: Needed? */ > /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */ Thanks a lot! For the next patch please add a sign-off line, otherwise we cannot commit your patch. See also http://www.linuxbios.org/Development_Guidelines Cheers, Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
Index: it8712f/it8712f_early_serial.c
===================================================================
--- it8712f/it8712f_early_serial.c (Revision 2510)
+++ it8712f/it8712f_early_serial.c (Arbeitskopie)
@@ -77,8 +77,8 @@
it8712f_sio_write(IT8712F_GAME, 0x30, 0x1); /* GAME port */
it8712f_sio_write(IT8712F_IR, 0x30, 0x1); /* Consumer IR */
- /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
- /* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01); */
+ /* Select 24MHz CLKIN (set bit 0). */
+ it8712f_sio_write(0x00, IT8712F_CONFIG_REG_CLOCKSEL, 0x01);
/* Clear software suspend mode (clear bit 0). TODO: Needed? */
/* it8712f_sio_write(0x00, IT8712F_CONFIG_REG_SWSUSP, 0x00); */
Index: it8705f/it8705f_early_serial.c
===================================================================
--- it8705f/it8705f_early_serial.c (Revision 2510)
+++ it8705f/it8705f_early_serial.c (Arbeitskopie)
@@ -77,8 +77,8 @@
it8705f_sio_write(IT8705F_IR, 0x30, 0x1); /* Consumer IR */
it8705f_sio_write(IT8705F_MIDI, 0x30, 0x1); /* MIDI port */
- /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
- /* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01); */
+ /* Select 24MHz CLKIN (set bit 0). */
+ it8705f_sio_write(0x00, IT8705F_CONFIG_REG_CLOCKSEL, 0x01);
/* Clear software suspend mode (clear bit 0). TODO: Needed? */
/* it8705f_sio_write(0x00, IT8705F_CONFIG_REG_SWSUSP, 0x00); */
Index: it8716f/it8716f_early_serial.c
===================================================================
--- it8716f/it8716f_early_serial.c (Revision 2510)
+++ it8716f/it8716f_early_serial.c (Arbeitskopie)
@@ -77,8 +77,8 @@
it8716f_sio_write(IT8716F_GAME, 0x30, 0x1); /* GAME port */
it8716f_sio_write(IT8716F_IR, 0x30, 0x1); /* Consumer IR */
- /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
- /* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01); */
+ /* Select 24MHz CLKIN (set bit 0). */
+ it8716f_sio_write(0x00, IT8716F_CONFIG_REG_CLOCKSEL, 0x01);
/* Clear software suspend mode (clear bit 0). TODO: Needed? */
/* it8716f_sio_write(0x00, IT8716F_CONFIG_REG_SWSUSP, 0x00); */
Index: it8673f/it8673f_early_serial.c
===================================================================
--- it8673f/it8673f_early_serial.c (Revision 2510)
+++ it8673f/it8673f_early_serial.c (Arbeitskopie)
@@ -85,7 +85,7 @@
it8673f_sio_write(IT8673F_KBCK, 0x30, 0x1); /* Keyboard */
it8673f_sio_write(IT8673F_KBCM, 0x30, 0x1); /* Mouse */
- /* Select 24MHz CLKIN (clear bit 0). TODO: is this really needed? */
+ /* Select 24MHz CLKIN (clear bit 0). */
it8673f_sio_write(0x00, IT8673F_CONFIG_REG_CLOCKSEL, 0x00);
/* Clear software suspend mode (clear bit 0). */
Index: it8718f/it8718f_early_serial.c
===================================================================
--- it8718f/it8718f_early_serial.c (Revision 2510)
+++ it8718f/it8718f_early_serial.c (Arbeitskopie)
@@ -75,8 +75,8 @@
it8718f_sio_write(IT8718F_KBCM, 0x30, 0x1); /* Mouse */
it8718f_sio_write(IT8718F_IR, 0x30, 0x1); /* Consumer IR */
- /* Select 24MHz/48MHz CLKIN (set/clear bit 0). TODO: Needed? */
- /* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01); */
+ /* Select 24MHz CLKIN (set bit 0). */
+ it8718f_sio_write(0x00, IT8718F_CONFIG_REG_CLOCKSEL, 0x01);
/* Clear software suspend mode (clear bit 0). TODO: Needed? */
/* it8718f_sio_write(0x00, IT8718F_CONFIG_REG_SWSUSP, 0x00); */
signature.asc
Description: Digital signature
-- linuxbios mailing list [email protected] http://www.openbios.org/mailman/listinfo/linuxbios
