Ok, the reason I did not add my name initially was because I felt since they were based on the i855pm that I didn't hold the right to copyright the whole file. But if you think it is ok then sure. Also I didn't know who the original authors were so I wasn't able to add them to the header.
Thanks for the fix. Jon On 12/19/06, Uwe Hermann <[EMAIL PROTECTED]> wrote: > Hi, > > thanks for the patch(es). > > On Tue, Dec 19, 2006 at 06:19:48PM -0500, Jon Dufresne wrote: > > Add initial support for i855gme. This is a work in progress and I > > don't expect it to work on all boards, or even any besides mine. This > > is based heavily on i855pm. > > > > Signed off by Jon Dufresne <[EMAIL PROTECTED]> > > Use a literal > Signed-off-by: Jon Dufresne <[EMAIL PROTECTED]> > please. > > > Attached is an updated patch which has a complete and correct (AFAICT) > license header. Your license headers were missing author(s) and date. > > The trivial files and those you wrote from scratch are now > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > and some of them are (also) copyrighted by others. > > I reconstructed some licensing info from the svn logs. Please let me > know if my conclusions are not correct. > > > > Index: src/northbridge/intel/i855gme/Config.lb > > Trivial. > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > > Index: src/northbridge/intel/i855gme/reset_test.c > > Trivial. > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > > Index: src/northbridge/intel/i855gme/raminit.c > > Written from scratch. > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > > Index: src/northbridge/intel/i855gme/debug.c > > Judging from > http://tracker.linuxbios.org/trac/LinuxBIOS/log/trunk/LinuxBIOSv2/src/mainboard/via/epia/debug.c > which seems to be the first occurence of any debug.c in the code, this > was written by Ron in 2003, so: > * Copyright (C) 2003 Ronald G. Minnich <[email protected]> > > Is this correct? The commit comment says "via epia; also yh lu tyan.". > Does that mean YH is the author? > > > > Index: src/northbridge/intel/i855gme/northbridge.c > > Judging from > http://tracker.linuxbios.org/trac/LinuxBIOS/log/trunk/LinuxBIOSv2/src/northbridge/via/vt8601/northbridge.c > which seems to be the first occurence of a northbridge.c which this one > is based on, this was written by Ron in 2003 and modified by Eric in > 2003,2004, so: > * Copyright (C) 2003 Ronald G. Minnich <[email protected]> > * Copyright (C) 2003-2004 Eric W. Biederman <[email protected]> > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > > Index: src/northbridge/intel/i855gme/chip.h > > Trivial. > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > > Index: src/northbridge/intel/i855gme/i855gme.h > > Currently empty. If you add code here, please add a license header. > > > > Index: src/northbridge/intel/i855gme/raminit.h > > Trivial. > * Copyright (C) 2006 Jon Dufresne <[EMAIL PROTECTED]> > > > HTH, Uwe. > -- > http://www.hermann-uwe.de | http://www.holsham-traders.de > http://www.crazy-hacks.org | http://www.unmaintained-free-software.org > > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.6 (GNU/Linux) > > iD8DBQFFiI6HXdVoV3jWIbQRAjUwAKCZfoMIdPCSbYSJigpvJKzE0JDtqgCgimnv > rEju4m67l/Ob2/08Vnv4N0U= > =YyT7 > -----END PGP SIGNATURE----- > > > -- > linuxbios mailing list > [email protected] > http://www.openbios.org/mailman/listinfo/linuxbios > > > -- linuxbios mailing list [email protected] http://www.openbios.org/mailman/listinfo/linuxbios
