Hi, On Fri, Mar 02, 2007 at 02:22:37PM +0100, Luc Verhaegen wrote: > This fixes the warning that's present for all VT8235 southbridges: > > ... > Enabling flash write on VT8235...tried to set 0x4 to 0x14 on VT8235 failed > (WARNING ONLY) > ... > > It's bourne from misinterpreting the return value of pci_write_byte, > which peculiarly returns 1 for success. > > Luc Verhaegen.
> flashrom: Fix wrong VT8235 flash enable failed warning. > > * Fix harmless but worrying warning where the return value of > pci_write_byte is misinterpreted. > * Hash together VT8231 and VT8235 code into VT823x. VT8231 is the better > implementation, but lacked the write protect disable code that's > apparently needed for VT8235. > > Signed-off-by: Luc Verhaegen <[EMAIL PROTECTED]> Looks reasonable to me, but I cannot test this. Have you tested the patch on both vt8235 and vt8231 (actual hardware)? Any complaints from anybody? Otherwise I guess we can commit this. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list [email protected] http://www.openbios.org/mailman/listinfo/linuxbios
