On Sat, Mar 03, 2007 at 07:11:35PM +0100, Stefan Reinauer wrote:
> * [EMAIL PROTECTED] <[EMAIL PROTECTED]> [070302 20:34]:
> > Ok, I got it. pci_ids.h currently says:
> > 
> > #define PCI_DEVICE_ID_INTEL_82801DB_0       0x24c0
> > #define PCI_DEVICE_ID_INTEL_82801DB_2       0x24c2
> > #define PCI_DEVICE_ID_INTEL_82801DB_3       0x24c3
> > #define PCI_DEVICE_ID_INTEL_82801DB_4       0x24c4
> > #define PCI_DEVICE_ID_INTEL_82801DB_5       0x24c5
> > #define PCI_DEVICE_ID_INTEL_82801DB_6       0x24c6
> > #define PCI_DEVICE_ID_INTEL_82801DB_7       0x24c7
> > #define PCI_DEVICE_ID_INTEL_82801DB_11      0x24cb
> > #define PCI_DEVICE_ID_INTEL_82801DB_13      0x24cd
> > 
> > And it should say:
> > 
> > #define PCI_DEVICE_ID_INTEL_82801DB_ISA     0x24c0
> > #define PCI_DEVICE_ID_INTEL_82801DB_PCI     0x24c1
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB0 0x24c2
> > #define PCI_DEVICE_ID_INTEL_82801DB_SMB     0x24c3
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB1 0x24c4
> > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_AUDIO 0x24c5
> > #define PCI_DEVICE_ID_INTEL_82801DB_AC97_MODEM 0x24c6
> > #define PCI_DEVICE_ID_INTEL_82801DB_USB2 0x24c7
> > #define PCI_DEVICE_ID_INTEL_82801DB_IDE     0x24cb
> > #define PCI_DEVICE_ID_INTEL_82801DB_EHCI 0x24cd
> > 
> > Can someone apply this fix for me?
> 
> Can you provide a unified diff (svn diff) and send it to the list?

The pci_ids.h from the Linux kernel (which ours is based on) has only
the PCI_DEVICE_ID_INTEL_82801DB_12 etc. defines (with numbers).

Shall we fix our code to use the numbers? Or maybe add something like
this at the end of pci_ids.h:

#define PCI_DEVICE_ID_INTEL_82801DB_ISA  PCI_DEVICE_ID_INTEL_82801DB_0
#define PCI_DEVICE_ID_INTEL_82801DB_USB0 PCI_DEVICE_ID_INTEL_82801DB_2
...

I'd like to stay as close as reasonably possible to the pci_ids.h from
Linux, so that we can easily sync with the Linux version from time to
time...


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

Attachment: signature.asc
Description: Digital signature

-- 
linuxbios mailing list
[email protected]
http://www.openbios.org/mailman/listinfo/linuxbios

Reply via email to