On Tue, May 29, 2007 at 03:03:57AM -0400, Corey Osgood wrote: > Acked-by: Corey Osgood <[EMAIL PROTECTED]>
Thanks, committed in r2703. > Just one question though: > > > #define PCI_DEVICE_ID_INTEL_82371AB 0x7111 > > #define PCI_DEVICE_ID_INTEL_82371AB_2 0x7112 > > #define PCI_DEVICE_ID_INTEL_82371AB_3 0x7113 > > +#define PCI_DEVICE_ID_INTEL_82371AB_ISA 0x7110 > > +#define PCI_DEVICE_ID_INTEL_82371AB_IDE 0x7111 > > +#define PCI_DEVICE_ID_INTEL_82371AB_USB 0x7112 > > +#define PCI_DEVICE_ID_INTEL_82371AB_ACPI 0x7113 /* Same as SMB */ > > +#define PCI_DEVICE_ID_INTEL_82371AB_SMB 0x7113 /* Same as ACPI > > */ > > Why add these and not remove the old ones? I can already hear someone > complaining about syncing up with the linux version, but I don't think > v2 will ever do that again, and why should we be cursed with linux's > obstrufication? Yeah, I agree, we can remove them. For v3 we already decided _not_ to use the kernel's pci_ids.h but rather maintain our own tight list of just the IDs we really need. I think we should only use the _ISA/_IDE/etc. versions in the code, the _0/_2/etc. is pretty much useless and unreadable, IMHO. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list [email protected] http://www.linuxbios.org/mailman/listinfo/linuxbios
