--- Begin Message ---
Uwe Hermann wrote:
On Tue, Jul 03, 2007 at 06:19:48PM -0600, Marc Jones wrote:
Yep, but the 0x56 and 0x12 should be #defines (or have comments), too.
The 0x56 and 0x12 are well commented in the function header.
Ah, yes, I should have looked a bit closer.
Moved some generic 8254 PIT #defines out of the speaker code to legacy.h.
Use legacy.h PIT defines in Geode code.
Signed-off-by: Marc Jones <[EMAIL PROTECTED]>
Looks good to me.
Acked-by: Uwe Hermann <[EMAIL PROTECTED]>
Uwe.
r433
Thanks,
Marc
--
Marc Jones
Senior Software Engineer
(970) 226-9684 Office
mailto:[EMAIL PROTECTED]
http://www.amd.com/embeddedprocessors
--- End Message ---
--
linuxbios mailing list
[email protected]
http://www.linuxbios.org/mailman/listinfo/linuxbios
