On Wed, Aug 29, 2007 at 09:27:59PM +0200, Markus Boas wrote: > I hope this one is better
Almost, please add the Signed-off-by to _all_ patches you send
(you forgot it on this patch), and please also include the README
update in this patch.
> Index: flash.h
> ===================================================================
> --- flash.h (Revision 2751)
> +++ flash.h (Arbeitskopie)
> @@ -100,7 +100,9 @@
>
> #define WINBOND_ID 0xDA /* Winbond */
> #define W_29C011 0xC1
> +#define W_29EE011 0xC1
> #define W_29C020C 0x45
> +#define W_29C040P 0x46
Why is this W_29C040P here? I don't see it used anywhere.
I guess we should remove it from the patch?
> Index: w29ee011.c
> ===================================================================
> --- w29ee011.c (Revision 0)
> +++ w29ee011.c (Revision 0)
> @@ -0,0 +1,58 @@
> +/*
> + * This file is part of the LinuxBIOS project.
^^^^^^^^^
Make this "flashrom" please
Please repost with a Signed-off-by and the above fixes, I think this
is ready to be committed otherwise.
Uwe.
--
http://www.hermann-uwe.de | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
signature.asc
Description: Digital signature
-- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
