On Tue, Sep 25, 2007 at 12:13:39AM +0200, [EMAIL PROTECTED] wrote:
> +# Debugging
> +DEBUG_ALL = 1

Do you really want this as the default? Should be a config option maybe
and default to off (if all of this usually Just Works).


> +$(SOURCE_DIR)/$(KERNEL_SOURCE):
> +     @ mkdir -p $(SOURCE_DIR)
         ^
   Why a space here?


> +     @ wget -P $(SOURCE_DIR) $(KERNEL_URL)/$(KERNEL_SOURCE)
> +
> +$(SOURCE_DIR)/$(TINY_SOURCE):
> +     @ mkdir -p $(SOURCE_DIR)
> +     @ wget -P $(SOURCE_DIR) $(TINY_URL)/$(TINY_SOURCE)


> ++  option CONFIG_COMPRESSED_PAYLOAD_LZMA=1
> ++  option CONFIG_PRECOMPRESSED_PAYLOAD=1
> ++  option ROM_IMAGE_SIZE=0x17000
> ++  option XIP_ROM_SIZE=0x40000

Make all values readable as in 'xyz * 1024' please. Why should we
obfuscate this stuff more than necessary?


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

Attachment: signature.asc
Description: Digital signature

-- 
linuxbios mailing list
[email protected]
http://www.linuxbios.org/mailman/listinfo/linuxbios

Reply via email to