On 16.11.2007 01:17, Peter Stuge wrote: > On Thu, Nov 15, 2007 at 06:13:41PM +0100, Carl-Daniel Hailfinger wrote: > >> Improve printk documentation to match code realities. >> > > Nak, for some hunks. > > At some point I hope that LB printk will end up in the kernel message > buffer. Then, we are able to handle anything from time zero, so let's > not remove any printks. The tidying is good though! >
printk() from time zero (to a buffer) will be enabled by one of my future patches. But right now the code should be consistent. - printk(BIOS_DEBUG, "Done %s\n", __FUNCTION__); Besides that, the only printk I removed will be directly followed by the LinuxBIOS banner about two instructions later and the printk itself is not as informative as I'd like. I will re-add a printk in that function with the late rprintk buffering patch. Regards, Carl-Daniel -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios
