Author: uwe Date: 2007-11-29 03:43:50 +0100 (Thu, 29 Nov 2007) New Revision: 2992
Modified: trunk/util/superiotool/README trunk/util/superiotool/smsc.c trunk/util/superiotool/superiotool.8 trunk/util/superiotool/superiotool.c trunk/util/superiotool/winbond.c Log: Various small fixes (trivial). - Add missing contributors to the README. - Drop obsolete -D option from manpage. - Only list contributors who added non-trivial amounts of code as copyright holders (and do not list those who merely provided register dump support for Super I/Os). Those contributors are still listed in the README, of course. See discussion in the thread starting at http://www.linuxbios.org/pipermail/linuxbios/2007-October/025516.html - Make a function static. - Fix incorrect URL in code comment. Drop obsolete comments. Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]> Acked-by: Uwe Hermann <[EMAIL PROTECTED]> Modified: trunk/util/superiotool/README =================================================================== --- trunk/util/superiotool/README 2007-11-29 02:28:55 UTC (rev 2991) +++ trunk/util/superiotool/README 2007-11-29 02:43:50 UTC (rev 2992) @@ -87,10 +87,13 @@ Carl-Daniel Hailfinger <[EMAIL PROTECTED]> David Hendricks <[EMAIL PROTECTED]> +Frieder Ferlemann <[EMAIL PROTECTED]> +Idwer Vollering <[EMAIL PROTECTED]> Rasmus Wiman <[EMAIL PROTECTED]> Robinson P. Tryon <[EMAIL PROTECTED]> Ronald Minnich <[EMAIL PROTECTED]> Stefan Reinauer <[EMAIL PROTECTED]> +Ulf Jordan <[EMAIL PROTECTED]> Uwe Hermann <[EMAIL PROTECTED]> Ward Vandewege <[EMAIL PROTECTED]> Modified: trunk/util/superiotool/smsc.c =================================================================== --- trunk/util/superiotool/smsc.c 2007-11-29 02:28:55 UTC (rev 2991) +++ trunk/util/superiotool/smsc.c 2007-11-29 02:43:50 UTC (rev 2992) @@ -326,7 +326,7 @@ {EOT}}}, {0x6e, "LPC47B387", { /* TODO: Not yet in sensors-detect */ /* Found in the HP Compaq Business Desktop d530 Series */ - /* http://thread.gmane.org/gmane.linux.bios/26648 */ + /* http://article.gmane.org/gmane.linux.bios/27192 */ /* We cannot find a public datasheet for this Super I/O. */ {EOT}}}, {0x6f, "LPC47B397", { Modified: trunk/util/superiotool/superiotool.8 =================================================================== --- trunk/util/superiotool/superiotool.8 2007-11-29 02:28:55 UTC (rev 2991) +++ trunk/util/superiotool/superiotool.8 2007-11-29 02:43:50 UTC (rev 2992) @@ -24,8 +24,8 @@ If no command line option is specified, .B superiotool merely tries to detect the Super I/O chip. -You must use either the -.BR "\-d" " or the " "\-D" +You must use the +.B "\-d" option to dump the Super I/O register contents. .TP .B "\-d, \-\-dump" Modified: trunk/util/superiotool/superiotool.c =================================================================== --- trunk/util/superiotool/superiotool.c 2007-11-29 02:28:55 UTC (rev 2991) +++ trunk/util/superiotool/superiotool.c 2007-11-29 02:43:50 UTC (rev 2992) @@ -115,7 +115,7 @@ printf(" NA"); else if (idx[k] == RSVD) printf(" RR"); - else if (idx[k] == MISC) /* TODO */ + else if (idx[k] == MISC) printf(" MM"); else printf(" %02x", idx[k]); Modified: trunk/util/superiotool/winbond.c =================================================================== --- trunk/util/superiotool/winbond.c 2007-11-29 02:28:55 UTC (rev 2991) +++ trunk/util/superiotool/winbond.c 2007-11-29 02:43:50 UTC (rev 2992) @@ -2,7 +2,6 @@ * This file is part of the superiotool project. * * Copyright (C) 2007 Uwe Hermann <[EMAIL PROTECTED]> - * Copyright (C) 2007 Rasmus Wiman <[EMAIL PROTECTED]> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -389,7 +388,7 @@ outb(0x86, port); } -void probe_idregs_winbond_helper(const char *init, uint16_t port) +static void probe_idregs_winbond_helper(const char *init, uint16_t port) { uint16_t id; uint8_t devid, rev, olddevid; @@ -425,14 +424,11 @@ get_superio_name(reg_table, id), devid, rev, port); chip_found = 1; - /* TODO: Special notes in dump output for the MISC entries. */ dump_superio("Winbond", reg_table, port, id); } void probe_idregs_winbond(uint16_t port) { - /* TODO: Not all init sequences are valid for all ports. */ - enter_conf_mode_winbond_88(port); probe_idregs_winbond_helper("(init=0x88) ", port); exit_conf_mode_winbond_fintek_ite_8787(port); -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios