Carl-Daniel Hailfinger wrote:
> On 29.11.2007 11:23, Stefan Reinauer wrote:
>   
>> * Carl-Daniel Hailfinger <[EMAIL PROTECTED]> [071128 01:20]:
>>   
>>     
>>> Reorder the rules in mainboard/*/*/Makefile so their order is identical
>>> across all of these makefiles. The rules are now in order of execution
>>> during boot, that is:
>>> STAGE0_MAINBOARD_OBJ
>>> INITRAM_OBJ
>>> STAGE2_MAINBOARD_OBJ
>>> As added benefit, mainboard makefiles are now almost identical.
>>>
>>> Signed-off-by: Carl-Daniel Hailfinger <[EMAIL PROTECTED]>
>>>     
>>>       
>> While you are at it, could you also change the _OBJ collections to
>> gather source files instead?
>>
>> In case of initram, the filenames in INITRAM_OBJ are changed on the fly,
>> so that's misleading. Generating a list of source files looks clearer,
>> and can accordingly replaced when being used
>>  $(patsubst %.c,$(obj)/%_xip.o,$(INITRAM_SOURCE))
>>   
>>     
>
> I'd prefer to do that in a separate patch. Is that OK for you?
>
> Regards,
> Carl-Daniel
>
>   
any time :-)

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


Attachment: signature.asc
Description: OpenPGP digital signature

-- 
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios

Reply via email to