I'd like to reach some consensus on a few things I'd like to make
"improvements" to:
- Obsoleting the DBG macro and replace it with:
#define PRINTK(x...) printk(x)
Obsoleting the DBG macro is to avoid the tendency to use the same debug
level for everything. The addition of the PRINTK macro preserves the
ability to remove the code for debug output to reduce executable size.
- Re-organize hardwaremain.c so that it calls the mainboard_fixup() and
mainboard_fixup calls utility functions in hardware main for most of
the code that is currently in intel_main(). The current setup is
awkward because it has mainboard_fixup() and then
final_mainboard_fixup() and yet still isn't very flexible. "Inverting"
the function calls like this will prevent endless additions of #ifdef
so that it can be customized to the needs of any board.
- Do the same for linuxbiosmain.c. In particular I can see the need to
be able to choose a different kernel and/or different kernel command
line based on some tests.
- Do the fixed mtrr tables in a manner similar to the irq routing tables
so that we can have mtrr tables for each board type.
How do people feel about this? If I did the work and submitted patches
for these changes would they be considered an improvement?
Cheers!
Ty
--
Tyson D Sawyer iRobot Corporation
Senior Systems Engineer Real World Interface Div.
[EMAIL PROTECTED] Robots for the Real World
603-532-6900 ext 206 http://www.irobot.com
