Eric,

I have just got back from a short absence and found that you had committed
your code updates.

Thanks for sorting out the start32.inc code - should be much better now.

A few comments:

Using a config file from the previous tree, I ran into some problems
immediately, some of which I have tracked down, others of which I am still
working on:

1. Makefile issue.

This is a small issue, but may be a gotcha for some others, the config file
name is now trated as an absolute pathname in the python command line for
creating the Makefile etc, so whereas previously the following command:

python ~/freebios/util/config/NLBConfig.py <configfile> ~/freebios

created the Makefile correctly, this command now requires

python ~/freebios/util/config/NLBConfig.py Absolutepath/<configfile>
~/freebios

2. Have you tested the code without SMP support? The tree seems to be broken
where there is no SMP support required.

For sure in include/smp/atomic.h, the define for atomic_dec is wrong - well
atomic_inc is defined twice.

I have corrected this, but then there are a whole lot of other compile
issues now - I will keep you posted.

Regards

Hamish


Reply via email to