|
Hi Folks,
Attached is another update of
NLBConfig:
- Added many comments to the python
code.
- Removed the TOP command because it was broken and
probably not needed.
- Removed the pcibridge command because it was
broken and probably not needed (can use 'dir' command instead, if
needed).
- Some other code cleanup.
- Substantial testing, by comparing the output
files generated by my NLBConfig and recent NLBConfig.py
- No more major changes planned.
Also attached is LBCtest, a regression test for
NLBConfig, and LBCtest-config-files, a list of config files used by the
regression test.
Eric, since you are going to look at Ollie's
src/pc80/ide problem, could you make any bug fixes to my version and check it
in? And also the regression test, if you like. I would look at
Ollie's problem, except 1) I just saw his mail, 2) I don't understand what the
complaint is (a config file would help), and 3) it's past my bedtime
:-)
A couple of comments arising from this
exercise:
- Should NLBConfig be renamed to LBConfig?
The "New" isn't very meaningful, I think.
- I know that commands such as northbridge, docipl
and nsuperio need to stay around for compatibility with existing config
files. But I would suggest that no further such specialized commands be
added. northbridge and several other commands could be done just as well
with the "dir" command, and some of the other specialized commands could be
handled with config scripts. If more extensions to NLBConfig are needed, I
suggest doing them in a general way, and put LinuxBIOS specialized stuff into
Config scripts.
Cheers,
- Jan
|
NLBConfig
Description: Binary data
LBCtest
Description: Binary data
LBCtest-config-files
Description: Binary data
