I made the original change that caused this:

http://cvs.sourceforge.net/viewcvs.py/etherboot/etherboot/etherboot-5.3/src/core/Attic/osloader.c?r1=1.5&r2=1.6&diff_format=u

At the time the change was made to fix an issue that was reported to cause Etherboot to fail to boot some kernels. IIRC, EB failed to recognize that the kernel download was complete. However, the fix seems to have broken memtest and FreeBSD.

From my point of view the this patch should be accepted to revert to the original functionality. I think this may cause the original problem that I tried to correct to reappear but that may help someone fix the real problem correctly this time.

Regards

Tim

yhlu wrote:
Great,

Tim, Can you verify that?

YH

On 7/15/05, Steven J. Magnani <[EMAIL PROTECTED]> wrote:

I think this patch fixes the bug.

--- etherboot-5.4.0/src/core/osloader.c.orig    2005-02-15
19:46:56.000000000 -0600
+++ etherboot-5.4.0/src/core/osloader.c 2005-07-15 14:13:39.234375000
-0500
@@ -350,10 +350,11 @@
      else {
              len -= (skip_sectors << 9) + skip_bytes;
              data += (skip_sectors << 9) + skip_bytes;
+               skip_sectors = os_download(data, len, eof);
+               skip_bytes = 0;
+
      }
-       skip_sectors = os_download(data, len, eof);
-       skip_bytes = 0;
-
+
      return 1;
}

Steve Magnani
www.digidescorp.com

-----Original Message-----
From: yhlu [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 14, 2005 9:10 AM
To: Steven J. Magnani
Cc: [EMAIL PROTECTED]; [email protected]
Subject: Re: [LinuxBIOS] etherboot with LinuxBIOS


do not use 5.4 at this time, because the memtest can not be loaded by
Etherboot 5.4 correctly.

YH

On 7/14/05, Steven J. Magnani <[EMAIL PROTECTED]> wrote:

Etherboot 5.4.0 seems to compile with gcc-3.4.3 if, in addition to the

config changes spelled out on the Wiki, you also comment out PXE
support in src/Config:

# Etherboot as a PXE network protocol ROM
#CFLAGS+=       -DPXE_IMAGE -DPXE_EXPORT

Seems to run, but I haven't reached a point where I can boot something

over the network yet.

Steve
www.digidescorp.com




_______________________________________________
LinuxBIOS mailing list
[email protected]
http://www.openbios.org/mailman/listinfo/linuxbios







-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_idt77&alloc_id492&op=click
_______________________________________________
Etherboot-users mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/etherboot-users



_______________________________________________
LinuxBIOS mailing list
[email protected]
http://www.openbios.org/mailman/listinfo/linuxbios

Reply via email to