Removing the dcassert sounds fine Converting in nmdchub sounds fine as long as the binary nick thing is done Validating the utf8 meant for display also sounds fine, assuming we replace any bad chars as opposed to discarding the whole message...or at least that seems like the most reasonable tradeoff unless you have a better idea?
I don't remember the code but I'm guessing most out-of-nmdc-conversions are done either in protocolspecific bits (search results?) or would go away were the binary nick thing implemented...in any case keeping it in nmdchub makes a lot of sense. -- ClientManager::findLegacyUser(), assertion "aNick.size() > 0" fails https://bugs.launchpad.net/bugs/321246 You received this bug notification because you are a member of LinuxDC++ Team, which is subscribed to LinuxDC++. Status in DC++: Fix Committed Status in Linux DC++: Confirmed Bug description: I have no idea why this happened. I was doing some testing (tried and true random clicking) on some Russian hub, and I can't make it happen again. The address of the hub was lost when the application failed assertion, unfortunately. linuxdcpp: dcpp/ClientManager.cpp:187: dcpp::UserPtr dcpp::ClientManager::findLegacyUser(const std::string&) const: Försäkran "aNick.size() > 0" falsk. _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : [email protected] Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
