it makes more sense to use the clearing method the library provides than to attach to a separate string.
although this is really micro-optimization, i wrote a little test (attached) just for the sake of the argument. results: - with GCC 4.5: s.clear() + re-assignment is 4 times faster than s = emptyString + re-assignment; - with MSVC 10: s.clear() + re-assignment is 1.5 times faster than s = emptyString + re-assignment; it takes 10 million iterations to obtain a measurable result so of course, this is absolutely meaningless, but still proves my point. :) ** Attachment added: "string clearing test" https://bugs.launchpad.net/dcplusplus/+bug/250149/+attachment/1753579/+files/test.cpp -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/250149 Title: Retry on more possible Coral errors Status in DC++: In Progress Bug description: From 0.707 it retiries automatically if the Coral network is not connectable. However, there's still a problem when a transfer fails from Coral or if a Coral server responds with a HTTP error. Devs of DC++ mods also reported this problem, adding that either all kinds of Coral errors should be handled or it should be disabled by default in the further releases. Here is a patch that solves the rest of the problems. Also it seems that the problem when Coral network overloaded so it redirected to a page informing about the network problems is changed. It gives HTTP 503 - Service unavailable for some time, so with the patch this shoud be handled as well. _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : [email protected] Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
