Is file name/path validation ever truly windows specifc. If the functions are currently only implemented and/or used on windows then that is an oversight considering there is an open bug regarding multiplatform compatibility (yes the function bodies may need to be different for other platforms, but things like resulting downloaded filelist names should be the same for all). So lets not make choices that will cause complications regarding that bug if it can be avoided.
-- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1317287 Title: Filelist Download Failure From Specific Usernames Status in ApexDC++ - The Pinnacle of File-Sharing: New Status in DC++: Confirmed Bug description: There is an issue with DC++ when a user chooses a nickname that happens to be a Windows Reserved Keyword. For example, if a user chooses a nickname from the following list: CON, PRN, AUX, NUL, COM1, COM2, COM3, COM4, COM5, COM6, COM7, COM8, COM9, LPT1, LPT2, LPT3, LPT4, LPT5, LPT6, LPT7, LPT8, LPT9 (Reference: http://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words) a Windows user trying to download the filelist from a user with one of these nicks will fail because the filename is in the format of *nick*.xml.bz2 (ex. "aux.xml.bz2"), which is disallowed under Windows. When DC++ attempts to write the remote user's filelist to disk, the download will hang because Windows blocks the writing of this file to disk. There is no error message displayed to the user during this process and the reasons for the download to hang are not clearly apparent. The person that is using this nick will have no issues, because their filelist is named files.xml.bz2 which is allowed. Ideally, the above list would be disallowed as a username so that Windows users can download their filelists. Other clients would need to adopt this blacklist as well to be good net citizens towards Windows users. To manage notifications about this bug go to: https://bugs.launchpad.net/apexdc/+bug/1317287/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
