ok, you didn't mean it that way but "should know better" is offensive in this context; it implies that it's foolish of authors not to have foreseen the issue. you wanted "would know more" / "would have more clue".
the patch is fine; i'll put it in soon unless another solution is found (on the caller side). -- You received this bug notification because you are a member of Dcplusplus-team, which is subscribed to DC++. https://bugs.launchpad.net/bugs/1386172 Title: startup.lua in scripting plugin breaks handshake with ADC hubs Status in DC++: New Bug description: Default startup.lua script included with ScriptPlugin breaks the handshake with any ADC(S) hub. Function adch.DataArrival checks for empty protocol message and returns nil in that case. For some reason this breaks the client to hub handshake. To fix this, function needs to return 1 instead. This bug was reproduces with DC++ 0.843 and ApexDC++ 1.6.0, both x64 builds running on Windows 7. My initial thread on ApexDC++ forum: http://forums.apexdc.net/topic/4678-still-cant-connect-to-adcs-hubs/ To manage notifications about this bug go to: https://bugs.launchpad.net/dcplusplus/+bug/1386172/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~linuxdcpp-team Post to : linuxdcpp-team@lists.launchpad.net Unsubscribe : https://launchpad.net/~linuxdcpp-team More help : https://help.launchpad.net/ListHelp
