On Mon, 2025-05-26 at 16:12 +0800, Ai Chao wrote: > Hi Johannes: > > > > "simplifies the code" is no need to callof_node_put() . > > Fair. Except that's not what you _actually_ changed here. Like I said, > > either it's buggy before or after. > > > In the function i2sbus_probe, it not return a struct device_node, so , I > think function for_each_child_of_node_scoped is better than > for_each_child_of_node.
You still haven't explained why it's even correct. johannes
