On Thu, 30 Oct 2025 21:51:00 +0100 Markus Elfring <[email protected]> wrote:
> From: Markus Elfring <[email protected]> > Date: Thu, 30 Oct 2025 21:43:20 +0100 > Subject: [PATCH] KVM: PPC: Use pointer from memcpy() call for assignment in > kvmppc_kvm_pv() > > A pointer was assigned to a variable. The same pointer was used for > the destination parameter of a memcpy() call. > This function is documented in the way that the same value is returned. > Thus convert two separate statements into a direct variable assignment for > the return value from a memory copy action. > > The source code was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <[email protected]> > --- > arch/powerpc/kvm/powerpc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/kvm/powerpc.c b/arch/powerpc/kvm/powerpc.c > index 2ba057171ebe..ae28447b3e04 100644 > --- a/arch/powerpc/kvm/powerpc.c > +++ b/arch/powerpc/kvm/powerpc.c > @@ -216,8 +216,7 @@ int kvmppc_kvm_pv(struct kvm_vcpu *vcpu) > > shared &= PAGE_MASK; > shared |= vcpu->arch.magic_page_pa & 0xf000; > - new_shared = (void*)shared; > - memcpy(new_shared, old_shared, 0x1000); > + new_shared = memcpy(shared, old_shared, 0x1000); Did you even try to compile this?? > vcpu->arch.shared = new_shared; > } > #endif
