Arnd Bergmann wrote: > On Monday 30 July 2007, Dave Jiang wrote: >>> What about the other option I mentioned, handling the EDAC stuff from the >>> fsl_add_bridge() function? >> I'm not sure I follow your thought on this quite yet. Do you mean the setup >> of >> either of_device or platform_device or do you mean the actual pci err driver? >> I'm not understanding how doing the setup code in fsl_add_bridge() would >> allow >> us to prevent the of_device being monopolized by the EDAC driver or the >> future >> PCI code.... The EDAC driver still needs some sort of "device" to claim one >> way >> or another right? > > What I meant is calling the edac_pci_alloc_ctl_info() function directly > from fsl_add_bridge() where appropriate, with all the 85xx PCI EDAC > code moved into fsl_pci.c.
I don't believe that EDAC core has been loaded at the time of 85xx PCI initialization. Plus, the EDAC driver can be loaded as a kernel module. So that probably won't work.... Also, instead of having centralized EDAC chip driver, now you have things scattered over various places. One probably needs to add 83xx and 86xx code as well and whatever else eventually. Maybe we are just better off adding entries in the DTS to get around this problem.... -- ------------------------------------------------------ Dave Jiang Software Engineer MontaVista Software, Inc. http://www.mvista.com ------------------------------------------------------ _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
