On Sep 12, 2007, at 11:36 AM, Scott Wood wrote:
> On Wed, Sep 12, 2007 at 11:20:06AM -0500, Kumar Gala wrote:
>> + [EMAIL PROTECTED] {
>> + reg = <0 0 0 0 0>;
>> + #size-cells = <2>;
>> + #address-cells = <3>;
>> + device_type = "pci";
>> + [EMAIL PROTECTED] {
>
> You need a ranges; in the pcie node, or else nothing can be translated
> through it. Linux may let us get away with it currently, but other
> parsing code won't.
ok, wasn't sure. will add that in.
>> + i8259: [EMAIL PROTECTED] {
>> + reg = <1 20 2
>> + 1 a0 2
>> + 1 4d0 2>;
>> + clock-frequency = <0>;
>> + interrupt-controller;
>> + device_type =
>> "interrupt-controller";
>> + #address-cells = <0>;
>> + #interrupt-cells = <2>;
>> + built-in;
>> + compatible = "chrp,iic";
>> + interrupts = <9 2>;
>> + interrupt-parent =
>> + <&mpic>;
>> + };
>
> I'd get rid of clock-frequency and built-in.
I'm leaving them for now to match the others, we can clean them all
up at the same time. Technically built-in is spec'd by the CHRP spec
for ISA/PCI.
As for clock-frequency, not sure where that came from.
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
