On Tue, 2007-10-02 at 15:19 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2007-09-17 at 16:05 +1000, Michael Ellerman wrote: > > Add a helper routine to map dcr's based on the "dcr-reg" property of > > a device node. > > > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > > Wouldn't it be more consistent to call it of_map_dcr ? Or maybe find an > even better name, but dcr_map_reg really sucks :-)
That would give us dcr_map(), dcr_unmap() and of_map_dcr() - which doesn't strike me as more consistent. I don't particularly like dcr_map_reg(), but I think it's at least obvious that it's a variant of dcr_map() and that it has something to do with a "reg" .. maybe even a "dcr-reg" :) cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
