Hi Jon, On Mon, 5 Nov 2007 23:25:35 -0500 "Jon Smirl" <[EMAIL PROTECTED]> wrote: > > + compatible = of_get_property(node, "compatible", &len); > + strlcpy(info.driver_name, compatible, len);
Of course, you will check len against sizeof(info.driver_name), right?
> -/* With some changes from Kyösti Mälkki <[EMAIL PROTECTED]>.
> +/* With some changes from Kyï¿œsti Mï¿œlkki <[EMAIL PROTECTED]>.
Did you mean to change this?
> + char **alias;
const char ** would be nicer.
> struct i2c_driver {
> int id;
> unsigned int class;
> +
> + /* Alias name for the driver. Used to support device trees on
> + * the PowerPC architecture. Device tree names take the form of
> + * vendor,chip. For example "epson,pcf8564". Alias is a list of
> + * strings terminated by a zero entry.
> + */
> + char **alias;
const char ** would be nicer;
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpXADQEA2eM8.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
