Since commit 5ba0086bfd0fa6ab25f7ce1870417301a26c104f, the dtc-checkfails.sh script does not check the return code from dtc. That's reasonable, since depending on the checks we're testing, dtc could either complete succesfully or return an error.
However, it's never right for dtc to SEGV or otherwise be killed by a signal. So the script should catch that, and fail the testcase if it happens. This patch implements this behaviour. Signed-off-by: David Gibson <[EMAIL PROTECTED]> Index: dtc/tests/dtc-checkfails.sh =================================================================== --- dtc.orig/tests/dtc-checkfails.sh 2007-12-07 15:34:17.000000000 +1100 +++ dtc/tests/dtc-checkfails.sh 2007-12-07 15:35:22.000000000 +1100 @@ -17,6 +17,10 @@ rm -f $TMPFILE $LOG verbose_run_log "$LOG" "$DTC" -o /dev/null "$@" ret="$?" +if [ "$ret" -gt 127 ]; then + FAIL "dtc killed by signal (ret=$ret)" +fi + for c in $CHECKS; do if ! grep -E "^(ERROR)|(Warning) \($c\):" $LOG > /dev/null; then FAIL "Failed to trigger check \"%c\"" -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev