On Wed, 12 Dec 2007 16:48:24 -0600 Scott Wood <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > >> + ep8248e_bcsr = of_iomap(ep8248e_bcsr_node, 0); > > > > of_node_put(ep8248e_bcsr_node; > > No, because we hold on to the node for later use in ep8248e_mdio_probe().
Sorry, you are right, I didn't notice that it was global ... > BTW, is there any actual node removal done that justifies dealing with > refcounts everywhere? In the hotplug code. So I guess it is not very relevant to you, but it is a pain to retrofit this stuff if it does become important more widely. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgpBL81AkQjCA.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev