Hi Grant, Just one nit ...
On Fri, 28 Dec 2007 16:52:36 -0700 Grant Likely <[EMAIL PROTECTED]> wrote: > > +static int __devinit c67x00_drv_probe(struct platform_device *pdev) > +{ > + struct c67x00_device *c67x00; > + struct c67x00_platform_data *pdata; > + struct resource *res, *res2; > + int ret, i; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -ENODEV; > + > + res2 = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + if (!res2) > + return -ENODEV; > + > + pdata = (struct c67x00_platform_data*)pdev->dev.platform_data; This cast is unnecessary. -- Cheers, Stephen Rothwell [EMAIL PROTECTED] http://www.canb.auug.org.au/~sfr/
pgpgMfPZ45Gvo.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev