On Thu, 2016-07-14 at 13:48 +0300, Dan Carpenter wrote:
> There was clearly supposed to be a break statement here. Currently we
> use the k2 ata timings instead of sh ata ones we intended. Probably no
> one has this hardware anymore so it likely doesn't make a difference
> beyond the static checker warning.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org>
Should probably also:
CC: sta...@vger.kernel.org
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index 7f0434f..0c5d3a9 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -707,6 +707,7 @@ set_timings_mdma(ide_drive_t *drive, int intf_type, u32
> *timings, u32 *timings2,
> *timings = ((*timings) & ~TR_133_PIOREG_MDMA_MASK) | tr;
> *timings2 = (*timings2) & ~TR_133_UDMAREG_UDMA_EN;
> }
> + break;
> case controller_un_ata6:
> case controller_k2_ata6: {
> /* 100Mhz cell */
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
