On Tue, 08 Jan 2008 00:56:27 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Stephen Rothwell wrote: > > > > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > > Please don't post patches as attachments. > > Ok.
Unfortunately, you are using thunderbird and so the patch is now wrapped.
There is a workaround, see Documentation/email-clients.txt.
> > Please split the assignments from the tests. Here and elsewhere.
> >
> I made the changes in my code. I am trying to leave the original code as
> much as possible.
Thats all we ask.
> >> + } else {
> >> + if (dev->irq != NO_IRQ){
> >> + iic_interrupt_mode(dev, 0);
> >> + free_irq(dev->irq, dev);
> >> + }
> >> + iounmap(dev->vaddr);
> >> + kfree(dev);
> >>
> >
> > Should these last two be after the below brace?
> >
> >
> I'm not really qualified to answer, but I will anyway ;) I assume the
> original author is basically saying if he cannot delete the adapter, it
> is unsafe to free the memory since the i2c code may still use it. If I
> have read that right, then I agree.
OK, I can see that this is a "that should not happen" condition.
> + if (iic_force_poll)
> + dev->irq = NO_IRQ;
> + else if ((dev->irq = irq_of_parse_and_map(np, 0)) == NO_IRQ)
You missed this one.
Overall looks better, except all your indentation is now 4 spaces. We use
a TAB character for each level of indentation and you should be able to
set your editor to *display* the TABs as 4 places if that is what you like.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp12BMPuL3qs.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list [email protected] https://ozlabs.org/mailman/listinfo/linuxppc-dev
