On Tue, 29 Nov 2016 10:06:43 +0100
Christophe LEROY <christophe.le...@c-s.fr> wrote:
> Le 29/11/2016 à 09:56, Nicholas Piggin a écrit :
> > Signed-off-by: Nicholas Piggin <npig...@gmail.com>
> > ---
> > arch/powerpc/xmon/xmon.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
> > index 7605455..435f5f5 100644
> > --- a/arch/powerpc/xmon/xmon.c
> > +++ b/arch/powerpc/xmon/xmon.c
> > @@ -1213,10 +1213,13 @@ bpt_cmds(void)
> > {
> > int cmd;
> > unsigned long a;
> > - int mode, i;
> > + int i;
> > struct bpt *bp;
> > +#ifndef CONFIG_8xx
>
> CONFIG_8xx is deprecated (ref arch/powerpc/platforms/Kconfig.cputype).
> CONFIG_PPC_8xx should be used instead.
Thanks for picking that up. Michael, can you adjust it if you merge
please?
>
> > + int mode;
>
> You could also have moved this declaration inside the switch {,
> something like
I tried that, couldn't decide that it was better (you also need badaddr).
Thanks,
Nick
