SPU_FS selects MEMORY_HOTPLUG, which is problematic because
MEMORY_HOTPLUG is user selectable, meaning we can end up with a broken
.config where MEMORY_HOTPLUG is enabled but its dependencies are not,
leading to build breakages.

The select of MEMORY_HOTPLUG for SPU_FS was added back in 2006, in
commit 4da30d15b6d5 ("[POWERPC] spufs: fix memory hotplug dependency").

However we reworked the spufs code and removed the dependency on memory
hotplug in 2007 in commit 78bde53e351b ("[POWERPC] spufs: remove need
for struct page for SPEs").

So drop the select as it's no longer needed and causes problems.

Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
 arch/powerpc/platforms/cell/Kconfig | 1 -
 1 file changed, 1 deletion(-)

v2: Rebase.

diff --git a/arch/powerpc/platforms/cell/Kconfig 
index d9088f0b8fcc..441ad3bad3db 100644
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -46,7 +46,6 @@ config SPU_FS
        default m
        depends on PPC_CELL
        select SPU_BASE
-       select MEMORY_HOTPLUG
          The SPU file system is used to access Synergistic Processing
          Units on machines implementing the Broadband Processor

Reply via email to