On Thu, Dec 08, 2016 at 09:12:13AM +0530, Aneesh Kumar K.V wrote: > In commit a4b349540a26af ("powerpc/mm: Cleanup LPCR defines") we updated > LPCR_VRMASD wrongly as below. > > -#define LPCR_VRMASD (0x1ful << (63-16)) > +#define LPCR_VRMASD_SH 47 > +#define LPCR_VRMASD (ASM_CONST(1) << LPCR_VRMASD_SH) > > We initialize the VRMA bits in LPCR to 0x00 in kvm. Hence using a different > mask value as above while updating lpcr should not have any impact. > > This patch updates it to the correct value > Fixes: a4b349540a26af ("powerpc/mm: Cleanup LPCR defines") we updated > > Reported-by: Ram Pai <linux...@us.ibm.com> > Signed-off-by: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> > --- > arch/powerpc/include/asm/reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/reg.h b/arch/powerpc/include/asm/reg.h > index 9e1499f98def..1c17e208db78 100644 > --- a/arch/powerpc/include/asm/reg.h > +++ b/arch/powerpc/include/asm/reg.h > @@ -337,7 +337,7 @@ > #define LPCR_DPFD_SH 52 > #define LPCR_DPFD (ASM_CONST(7) << LPCR_DPFD_SH) > #define LPCR_VRMASD_SH 47 > -#define LPCR_VRMASD (ASM_CONST(1) << LPCR_VRMASD_SH) > +#define LPCR_VRMASD (ASM_CONST(1f) << LPCR_VRMASD_SH)
Don't you need an 0x in there? Did you compile-test this? Paul.