On Tue, Jan 17, 2017 at 12:36:53PM -0600, Reza Arbab wrote: > On Tue, Jan 17, 2017 at 12:55:13PM +0530, Balbir Singh wrote: > > On Mon, Jan 16, 2017 at 01:07:46PM -0600, Reza Arbab wrote: > > > Use remove_pagetable() and friends for radix vmemmap removal. > > > > > > We do not require the special-case handling of vmemmap done in the x86 > > > versions of these functions. This is because vmemmap_free() has already > > > freed the mapped pages, and calls us with an aligned address range. > > > > > > So, add a few failsafe WARNs, but otherwise the code to remove physical > > > mappings is already sufficient for vmemmap. > > > > I wonder if we really need them? > > Not sure what the guideline is for a "this shouldn't happen" WARN. It could > save us some grief, should our vmemmap code ever start calling with an > unaligned range, like it does on x86. >
Fair enough Acked-by: Balbir Singh <bsinghar...@gmail.com>
