Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

[Thomas Falcon]

On 01/26/2017 12:28 PM, Stephen Hemminger wrote:
> On Wed, 25 Jan 2017 15:02:19 -0600
> Thomas Falcon <tlfal...@linux.vnet.ibm.com> wrote:
>
>>  static irqreturn_t ibmvnic_interrupt(int irq, void *instance)
>>  {
>>      struct ibmvnic_adapter *adapter = instance;
>> +    unsigned long flags;
>> +
>> +    spin_lock_irqsave(&adapter->crq.lock, flags);
>> +    vio_disable_interrupts(adapter->vdev);
>> +    tasklet_schedule(&adapter->tasklet);
>> +    spin_unlock_irqrestore(&adapter->crq.lock, flags);
>> +    return IRQ_HANDLED;
>> +}
>> +
> Why not use NAPI? rather than a tasklet
>
This interrupt function doesn't process packets, but message passing between 
firmware and driver for determining device capabilities and available 
resources, such as the number TX and RX queues.