On 1/22/08, Jon Loeliger <[EMAIL PROTECTED]> wrote:
> Based on the Kurobox DTS files.
>
> Signed-off-by: Andy Wilcox <[EMAIL PROTECTED]>
> Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]>
Comments below
> +
> +/ {
> + model = "StorCenter";
> + compatible = "storcenter";
Be specific! "iomega,storcenter". Even better if you put in the model number.
> +
> + [EMAIL PROTECTED] {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + device_type = "soc";
device_type should be dropped (but I know that requires changes to the
existing mpc82xx support code).
> + compatible = "fsl,mpc8241", "mpc10x";
fsl,mpc8241-immr would be better; this node describes the internally
memory mapped registers; not the entire soc.
> +
> + mpic: [EMAIL PROTECTED] {
> + #interrupt-cells = <2>;
> + #address-cells = <0>;
Is #address-cells needed? There are no child nodes.
> + chosen {
> + linux,stdout-path = "/soc/[EMAIL PROTECTED]";
/[EMAIL PROTECTED]/ perhaps?
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
