From: Balbir Singh > Sent: 30 August 2017 01:28 > ISA 300 defines hypervisor decrementer to be 64 bits in length. > This patch extends the print format for all archs to be 64 bits > > Signed-off-by: Balbir Singh <bsinghar...@gmail.com> > --- > arch/powerpc/xmon/xmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c > index 9e68f1d..1b26d53 100644 > --- a/arch/powerpc/xmon/xmon.c > +++ b/arch/powerpc/xmon/xmon.c > @@ -1749,7 +1749,7 @@ static void dump_206_sprs(void) > > printf("sdr1 = %.16lx hdar = %.16lx hdsisr = %.8x\n", > mfspr(SPRN_SDR1), mfspr(SPRN_HDAR), mfspr(SPRN_HDSISR)); > - printf("hsrr0 = %.16lx hsrr1 = %.16lx hdec = %.8x\n", > + printf("hsrr0 = %.16lx hsrr1 = %.16lx hdec = %.16lx\n", > mfspr(SPRN_HSRR0), mfspr(SPRN_HSRR1), mfspr(SPRN_HDEC)); > printf("lpcr = %.16lx pcr = %.16lx lpidr = %.8x\n", > mfspr(SPRN_LPCR), mfspr(SPRN_PCR), mfspr(SPRN_LPID));
On the face of it the patch doesn't do what the commit message says. Not only that it is really silly to print a 32bit value with 8 extra leading zero digits. Something more subtle was also wrong: There were 3 mfspr() calls, 2 printed with %lx and one with %x. That ought to generate a warning from gcc. David