On Thu, 14 Sep 2017 02:50:32 +0530
"Naveen N. Rao" <naveen.n....@linux.vnet.ibm.com> wrote:
> 1. This is only used in kprobes.c, so make it static.
> 2. Remove the un-necessary (ret == 0) comparison in the else clause.
>
> Signed-off-by: Naveen N. Rao <naveen.n....@linux.vnet.ibm.com>
Reviewed-by: Masami Hiramatsu <mhira...@kernel.org>
Thanks!
> ---
> arch/powerpc/kernel/kprobes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c
> index 367494dc67d9..c2a6ab38a67f 100644
> --- a/arch/powerpc/kernel/kprobes.c
> +++ b/arch/powerpc/kernel/kprobes.c
> @@ -239,7 +239,7 @@ void arch_prepare_kretprobe(struct kretprobe_instance
> *ri, struct pt_regs *regs)
> }
> NOKPROBE_SYMBOL(arch_prepare_kretprobe);
>
> -int try_to_emulate(struct kprobe *p, struct pt_regs *regs)
> +static int try_to_emulate(struct kprobe *p, struct pt_regs *regs)
> {
> int ret;
> unsigned int insn = *p->ainsn.insn;
> @@ -261,7 +261,7 @@ int try_to_emulate(struct kprobe *p, struct pt_regs *regs)
> */
> printk("Can't step on instruction %x\n", insn);
> BUG();
> - } else if (ret == 0)
> + } else
> /* This instruction can't be boosted */
> p->ainsn.boostable = -1;
>
> --
> 2.14.1
>
--
Masami Hiramatsu <mhira...@kernel.org>
