On Mon, Oct 16, 2017 at 4:36 PM, Michael Ellerman <m...@ellerman.id.au> wrote: > Balbir Singh <bsinghar...@gmail.com> writes: > >> diff --git a/arch/powerpc/kernel/mce_power.c >> b/arch/powerpc/kernel/mce_power.c >> index b76ca19..0e584d5 100644 >> --- a/arch/powerpc/kernel/mce_power.c >> +++ b/arch/powerpc/kernel/mce_power.c >> @@ -27,6 +27,36 @@ >> #include <asm/mmu.h> >> #include <asm/mce.h> >> #include <asm/machdep.h> >> +#include <asm/pgtable.h> >> +#include <asm/pte-walk.h> >> +#include <asm/sstep.h> >> +#include <asm/exception-64s.h> >> + >> +/* >> + * Convert an address related to an mm to a PFN. NOTE: we are in real >> + * mode, we could potentially race with page table updates. >> + */ > > That will blow some serious chunks if we're on pseries. > > It seems it can't be triggered on pseries at the moment, but only > because of the feature section around the call to > machine_check_handle_early(). > > We should maybe move the powernv only code in here inside an #ifdef > POWERNV, just for documentation purposes. But we can do that later. >
Will do that as a follow up thanks! I think the entire mce_power.c and mce.c can move to pseries, will validate with Mahesh and Nick as well. Balbir
