On Thu, 1970-01-01 at 00:00 +0000, Andrew Lunn wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you recognize the sender and know the > content is safe. > > > > Hi, just saw this and thought of a small patch I just wrote for mdio bus, o > > idea > > if it is relevant but here goes: > > > > From fe0b98d54a79779482700676331b4d10a0f3cada Mon Sep 17 00:00:00 2001 > > From: Joakim Tjernlund <joakim.tjernl...@infinera.com> > > Date: Sun, 14 Jan 2018 21:27:20 +0100 > > Subject: [PATCH] of_mdiobus_register: Continue after error > > > > of_mdiobus_register unregister itself if one phy fails to register > > which is bad for system having all its PHYs on the same MDIO bus. > > Just log the error and continue with the remaining PHYs instead. > > > > Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com> > > Hi Joakim > > You appear to be using an old kernel. Take a look at:
Not really, I am using 4.14.x and I don't think that is old. Seems like this patch hasn't been sent to 4.14.x. I wonder if I might be missing something else, we just moved to 4.14 and notic that all our fixed PHYs are non functioning: fsl_mac ffe4e2000.ethernet: FMan MEMAC fsl_mac ffe4e2000.ethernet: FMan MAC address: 00:06:9c:0b:06:20 fsl_mac dpaa-ethernet.0: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.0 failed with error -16 fsl_mac ffe4e4000.ethernet: FMan MEMAC fsl_mac ffe4e4000.ethernet: FMan MAC address: 00:06:9c:0b:06:21 fsl_mac dpaa-ethernet.1: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.1 failed with error -16 fsl_mac ffe4e6000.ethernet: FMan MEMAC fsl_mac ffe4e6000.ethernet: FMan MAC address: 00:06:9c:0b:06:22 fsl_mac dpaa-ethernet.2: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.2 failed with error -16 fsl_mac ffe4e8000.ethernet: FMan MEMAC fsl_mac ffe4e8000.ethernet: FMan MAC address: 00:06:9c:0b:06:23 fsl_mac dpaa-ethernet.3: __devm_request_mem_region(mac) failed fsl_mac: probe of dpaa-ethernet.3 failed with error -16 Feels like FMAN still think there are real PHYs there ? > > commit 95f566de0269a0c59fd6a737a147731302136429 > Author: Madalin Bucur <madalin.bu...@nxp.com> > Date: Tue Jan 9 14:43:34 2018 +0200 > > of_mdio: avoid MDIO bus removal when a PHY is missing > > If one of the child devices is missing the of_mdiobus_register_phy() > call will return -ENODEV. When a missing device is encountered the > registration of the remaining PHYs is stopped and the MDIO bus will > fail to register. Propagate all errors except ENODEV to avoid it. > > Signed-off-by: Madalin Bucur <madalin.bu...@nxp.com> > Reviewed-by: Andrew Lunn <and...@lunn.ch> > Signed-off-by: David S. Miller <da...@davemloft.net> > > > Andrew