On Mon, Feb 12, 2018 at 7:59 PM, Vaibhav Jain <vaib...@linux.vnet.ibm.com> wrote: > Presently sysrq key for xmon('x') is registered during kernel init > irrespective of the value of kernel param 'xmon'. Thus xmon is enabled > even if 'xmon=off' is passed on the kernel command line. > > This minor patch updates setup_xmon_sysrq() to register > 'sysrq_xmon_op' only when variable 'xmon_on' is set. > > Signed-off-by: Vaibhav Jain <vaib...@linux.vnet.ibm.com> > ---
Any specific issue you've run into without this patch? I presume running xmon=off indicates we don't want xmon to take over in case of panic/die/oops, why are we tying this to sysrq? Balbir Singh.