On Tue, Feb 13, 2018 at 10:01:57AM +1100, Balbir Singh wrote: > On Tue, Feb 13, 2018 at 9:34 AM, Guenter Roeck <li...@roeck-us.net> wrote: > > If KEXEC_CORE is not enabled, PowerNV builds fail as follows. > > > > arch/powerpc/platforms/powernv/smp.c: In function 'pnv_smp_cpu_kill_self': > > arch/powerpc/platforms/powernv/smp.c:236:4: error: > > implicit declaration of function 'crash_ipi_callback' > > > > Add dummy function calls, similar to kdump_in_progress(), to solve the > > problem. > > > > Fixes: 4145f358644b ("powernv/kdump: Fix cases where the kdump kernel ...") > > Cc: Balbir Singh <bsinghar...@gmail.com> > > Cc: Michael Ellerman <m...@ellerman.id.au> > > Cc: Nicholas Piggin <npig...@gmail.com> > > Signed-off-by: Guenter Roeck <li...@roeck-us.net> > > --- > > Thanks for working on this. > > You've added two functions, I understand the crash_send_ipi() bits > that I broke. Looks like crash_ipi_callback broken without KEXEC_CORE? >
If I recall correctly, 4145f358644b introduced the call to crash_ipi_callback(). After I declared the dummy function for that, I got an error about the missing crash_send_ipi(). I didn't spend more time on it but just added another dummy function. It may well be that another problem was introduced in the same time frame. On the other side, maybe I got it all wrong, and my patch is not worth the computer it was written on. Thanks, Guenter