Viresh Kumar <viresh.ku...@linaro.org> writes:
> Subject: Re: [PATCH 15/27] cpufreq: powerenv: Don't validate the frequency
> table twice
^
powernv
> The cpufreq core is already validating the CPU frequency table after
> calling the ->init() callback of the cpufreq drivers and the drivers
> don't need to do the same anymore. Though they need to set the
> policy->freq_table field directly from the ->init() callback now.
>
> Stop validating the frequency table from powerenv driver.
>
> Signed-off-by: Viresh Kumar <viresh.ku...@linaro.org>
> ---
> drivers/cpufreq/powernv-cpufreq.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/cpufreq/powernv-cpufreq.c
> b/drivers/cpufreq/powernv-cpufreq.c
> index 29cdec198657..0591874856d3 100644
> --- a/drivers/cpufreq/powernv-cpufreq.c
> +++ b/drivers/cpufreq/powernv-cpufreq.c
> @@ -812,7 +812,7 @@ static int powernv_cpufreq_target_index(struct
> cpufreq_policy *policy,
>
> static int powernv_cpufreq_cpu_init(struct cpufreq_policy *policy)
> {
> - int base, i, ret;
> + int base, i;
> struct kernfs_node *kn;
> struct global_pstate_info *gpstates;
Confusingly this function has two variables called ret, but the other
one is declared inside an if block below in context not shown.
So this hunk is correct.
> @@ -848,15 +848,10 @@ static int powernv_cpufreq_cpu_init(struct
> cpufreq_policy *policy)
> gpstates->timer.expires = jiffies +
> msecs_to_jiffies(GPSTATE_TIMER_INTERVAL);
> spin_lock_init(&gpstates->gpstate_lock);
> - ret = cpufreq_table_validate_and_show(policy, powernv_freqs);
> -
> - if (ret < 0) {
> - kfree(policy->driver_data);
> - return ret;
> - }
>
> + policy->freq_table = powernv_freqs;
> policy->fast_switch_possible = true;
> - return ret;
> + return 0;
> }
LGTM.
cheers
