On Thu, 5 Apr 2018 09:49:00 +1000 Nicholas Piggin <npig...@gmail.com> wrote:
> On Thu, 5 Apr 2018 09:19:41 +1000 > Balbir Singh <bsinghar...@gmail.com> wrote: > > > The code currently assumes PAGE_SHIFT as the shift value of > > the pfn, this works correctly (mostly) for user space pages, > > but the correct thing to do is > > It would be good to actually explain the problem in the > changelog. I would have thought pte_pfn returns a > PAGE_SIZE based pfn value? > The issue is hidden inside of hugepte_offset() as invoked by __find_linux_pte(). I will send a new version because the code needs to do << (shift - PAGE_SHIFT) for instruction address. > > > > 1. Extrace the shift value returned via the pte-walk API's > > ^^^ extract? Thanks, yes, typo! Balbir Singh.
