On 2/5/18 6:59 pm, Balbir Singh wrote: >>> >>>> + unsigned long subpg; >>> >>> Why not just i? >> >> I can imagine pages so huge so backing them with 4K will overflow 32bit >> anyway. It is very (very) unlikely but it is 64bit arch anyway and there is >> no much point in not-long types anyway. >> > > What David said, i is an easy iterator to understand :)
Ah, blind me. The reason for this is there is another "i" in the caller and I found it easier not to mix this "i" (host TCE entry number) with that "i" (guest TCE entry number). -- Alexey
