On Friday, June 22, 2018, 11:15:29 AM, Paul Clarke wrote: > On 06/22/2018 09:43 AM, Breno Leitao wrote: >> If you don't mind, I would solve this problem slightly different, as it seems >> to be more readable. >> >> - strncpy(prog, argv[0], strlen(argv[0])); >> + if (strlen(argv[0]) >= LEN_MAX){ >> + fprintf(stderr, "Very big executable name: %s\n", argv[0]);
> "Very big" is an observation. "Too big" indicates a problem > better. Or, more explicitly "Executable name is too long". Or even better, display the limit that is being exceeded, in case that value changes over time. Something like. - strncpy(prog, argv[0], strlen(argv[0])); + if (strlen(argv[0]) >= LEN_MAX){ + fprintf(stderr, "Executable name exceeds limit (%d): %s\n", + LEN_MAX, + argv[0]);