Hi Akshay, Thank you for the patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v4.18-rc3 next-20180702] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Akshay-Adiga/powernv-cpuidle-Device-tree-parsing-cleanup/20180703-024607 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc Note: the linux-review/Akshay-Adiga/powernv-cpuidle-Device-tree-parsing-cleanup/20180703-024607 HEAD 4beae9263d77036dae7f43905823867c6d982690 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/cpuidle/cpuidle-powernv.c: In function 'powernv_add_idle_states': >> drivers/cpuidle/cpuidle-powernv.c:417:28: error: 'state' undeclared (first >> use in this function); did you mean 'statx'? if (has_stop_states && !(state->valid)) ^~~~~ statx drivers/cpuidle/cpuidle-powernv.c:417:28: note: each undeclared identifier is reported only once for each function it appears in vim +417 drivers/cpuidle/cpuidle-powernv.c 262 263 extern u32 pnv_get_supported_cpuidle_states(void); 264 static int powernv_add_idle_states(void) 265 { 266 struct device_node *power_mgt; 267 int nr_idle_states = 1; /* Snooze */ 268 int dt_idle_states, count; 269 u32 latency_ns[CPUIDLE_STATE_MAX]; 270 u32 residency_ns[CPUIDLE_STATE_MAX]; 271 u32 flags[CPUIDLE_STATE_MAX]; 272 u64 psscr_val[CPUIDLE_STATE_MAX]; 273 u64 psscr_mask[CPUIDLE_STATE_MAX]; 274 const char *names[CPUIDLE_STATE_MAX]; 275 u32 has_stop_states = 0; 276 int i, rc; 277 u32 supported_flags = pnv_get_supported_cpuidle_states(); 278 279 280 /* Currently we have snooze statically defined */ 281 282 power_mgt = of_find_node_by_path("/ibm,opal/power-mgt"); 283 if (!power_mgt) { 284 pr_warn("opal: PowerMgmt Node not found\n"); 285 goto out; 286 } 287 288 /* Read values of any property to determine the num of idle states */ 289 dt_idle_states = of_property_count_u32_elems(power_mgt, "ibm,cpu-idle-state-flags"); 290 if (dt_idle_states < 0) { 291 pr_warn("cpuidle-powernv: no idle states found in the DT\n"); 292 goto out; 293 } 294 295 count = of_property_count_u32_elems(power_mgt, 296 "ibm,cpu-idle-state-latencies-ns"); 297 298 if (validate_dt_prop_sizes("ibm,cpu-idle-state-flags", dt_idle_states, 299 "ibm,cpu-idle-state-latencies-ns", 300 count) != 0) 301 goto out; 302 303 count = of_property_count_strings(power_mgt, 304 "ibm,cpu-idle-state-names"); 305 if (validate_dt_prop_sizes("ibm,cpu-idle-state-flags", dt_idle_states, 306 "ibm,cpu-idle-state-names", 307 count) != 0) 308 goto out; 309 310 /* 311 * Since snooze is used as first idle state, max idle states allowed is 312 * CPUIDLE_STATE_MAX -1 313 */ 314 if (dt_idle_states > CPUIDLE_STATE_MAX - 1) { 315 pr_warn("cpuidle-powernv: discovered idle states more than allowed"); 316 dt_idle_states = CPUIDLE_STATE_MAX - 1; 317 } 318 319 if (of_property_read_u32_array(power_mgt, 320 "ibm,cpu-idle-state-flags", flags, dt_idle_states)) { 321 pr_warn("cpuidle-powernv : missing ibm,cpu-idle-state-flags in DT\n"); 322 goto out; 323 } 324 325 if (of_property_read_u32_array(power_mgt, 326 "ibm,cpu-idle-state-latencies-ns", latency_ns, 327 dt_idle_states)) { 328 pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-latencies-ns in DT\n"); 329 goto out; 330 } 331 if (of_property_read_string_array(power_mgt, 332 "ibm,cpu-idle-state-names", names, dt_idle_states) < 0) { 333 pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-names in DT\n"); 334 goto out; 335 } 336 337 /* 338 * If the idle states use stop instruction, probe for psscr values 339 * and psscr mask which are necessary to specify required stop level. 340 */ 341 has_stop_states = (flags[0] & 342 (OPAL_PM_STOP_INST_FAST | OPAL_PM_STOP_INST_DEEP)); 343 if (has_stop_states) { 344 count = of_property_count_u64_elems(power_mgt, 345 "ibm,cpu-idle-state-psscr"); 346 if (validate_dt_prop_sizes("ibm,cpu-idle-state-flags", 347 dt_idle_states, 348 "ibm,cpu-idle-state-psscr", 349 count) != 0) 350 goto out; 351 352 count = of_property_count_u64_elems(power_mgt, 353 "ibm,cpu-idle-state-psscr-mask"); 354 if (validate_dt_prop_sizes("ibm,cpu-idle-state-flags", 355 dt_idle_states, 356 "ibm,cpu-idle-state-psscr-mask", 357 count) != 0) 358 goto out; 359 360 if (of_property_read_u64_array(power_mgt, 361 "ibm,cpu-idle-state-psscr", psscr_val, dt_idle_states)) { 362 pr_warn("cpuidle-powernv: missing ibm,cpu-idle-state-psscr in DT\n"); 363 goto out; 364 } 365 366 if (of_property_read_u64_array(power_mgt, 367 "ibm,cpu-idle-state-psscr-mask", 368 psscr_mask, dt_idle_states)) { 369 pr_warn("cpuidle-powernv:Missing ibm,cpu-idle-state-psscr-mask in DT\n"); 370 goto out; 371 } 372 } 373 374 count = of_property_count_u32_elems(power_mgt, 375 "ibm,cpu-idle-state-residency-ns"); 376 377 if (count < 0) { 378 rc = count; 379 } else if (validate_dt_prop_sizes("ibm,cpu-idle-state-flags", 380 dt_idle_states, 381 "ibm,cpu-idle-state-residency-ns", 382 count) != 0) { 383 goto out; 384 } else { 385 rc = of_property_read_u32_array(power_mgt, 386 "ibm,cpu-idle-state-residency-ns", 387 residency_ns, dt_idle_states); 388 } 389 390 for (i = 0; i < dt_idle_states; i++) { 391 unsigned int exit_latency, target_residency; 392 bool stops_timebase = false; 393 394 /* 395 * Skip the platform idle state whose flag isn't in 396 * the supported_cpuidle_states flag mask. 397 */ 398 if ((flags[i] & supported_flags) != flags[i]) 399 continue; 400 /* 401 * If an idle state has exit latency beyond 402 * POWERNV_THRESHOLD_LATENCY_NS then don't use it 403 * in cpu-idle. 404 */ 405 if (latency_ns[i] > POWERNV_THRESHOLD_LATENCY_NS) 406 continue; 407 /* 408 * Firmware passes residency and latency values in ns. 409 * cpuidle expects it in us. 410 */ 411 exit_latency = DIV_ROUND_UP(latency_ns[i], 1000); 412 if (!rc) 413 target_residency = DIV_ROUND_UP(residency_ns[i], 1000); 414 else 415 target_residency = 0; 416 > 417 if (has_stop_states && !(state->valid)) 418 continue; 419 420 if (flags[i] & OPAL_PM_TIMEBASE_STOP) 421 stops_timebase = true; 422 423 /* 424 * For nap and fastsleep, use default target_residency 425 * values if f/w does not expose it. 426 */ 427 if (flags[i] & OPAL_PM_NAP_ENABLED) { 428 if (!rc) 429 target_residency = 100; 430 /* Add NAP state */ 431 add_powernv_state(nr_idle_states, "Nap", 432 CPUIDLE_FLAG_NONE, nap_loop, 433 target_residency, exit_latency, 0, 0); 434 } else if (has_stop_states && !stops_timebase) { 435 add_powernv_state(nr_idle_states, names[i], 436 CPUIDLE_FLAG_NONE, stop_loop, 437 target_residency, exit_latency, 438 psscr_val[i], psscr_mask[i]); 439 } 440 441 /* 442 * All cpuidle states with CPUIDLE_FLAG_TIMER_STOP set must come 443 * within this config dependency check. 444 */ 445 #ifdef CONFIG_TICK_ONESHOT 446 else if (flags[i] & OPAL_PM_SLEEP_ENABLED || 447 flags[i] & OPAL_PM_SLEEP_ENABLED_ER1) { 448 if (!rc) 449 target_residency = 300000; 450 /* Add FASTSLEEP state */ 451 add_powernv_state(nr_idle_states, "FastSleep", 452 CPUIDLE_FLAG_TIMER_STOP, 453 fastsleep_loop, 454 target_residency, exit_latency, 0, 0); 455 } else if (has_stop_states && stops_timebase) { 456 add_powernv_state(nr_idle_states, names[i], 457 CPUIDLE_FLAG_TIMER_STOP, stop_loop, 458 target_residency, exit_latency, 459 psscr_val[i], psscr_mask[i]); 460 } 461 #endif 462 else 463 continue; 464 nr_idle_states++; 465 } 466 out: 467 return nr_idle_states; 468 } 469 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
