Hi Benjamin, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on v4.18 next-20180817] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Benjamin-Herrenschmidt/powerpc-powernv-pci-Work-around-races-in-PCI-bridge-enabling/20180817-113453 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-defconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=powerpc All errors (new ones prefixed by >>): arch/powerpc/platforms/powernv/pci-ioda.c: In function 'pnv_pci_enable_bridges': >> arch/powerpc/platforms/powernv/pci-ioda.c:3262:18: error: unused variable >> 'pdev' [-Werror=unused-variable] struct pci_dev *pdev; ^~~~ >> arch/powerpc/platforms/powernv/pci-ioda.c:3261:18: error: unused variable >> 'bus' [-Werror=unused-variable] struct pci_bus *bus; ^~~ >> arch/powerpc/platforms/powernv/pci-ioda.c:3260:18: error: unused variable >> 'phb' [-Werror=unused-variable] struct pnv_phb *phb; ^~~ cc1: all warnings being treated as errors vim +/pdev +3262 arch/powerpc/platforms/powernv/pci-ioda.c 3256 3257 static void pnv_pci_enable_bridges(void) 3258 { 3259 struct pci_controller *hose; > 3260 struct pnv_phb *phb; > 3261 struct pci_bus *bus; > 3262 struct pci_dev *pdev; 3263 3264 list_for_each_entry(hose, &hose_list, list_node) 3265 pnv_pci_enable_bridge(hose->bus); 3266 } 3267 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
